Support attribute access on enum members correctly #19422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sterliakov
commented
Jul 11, 2025
| @@ -1971,8 +1972,8 @@ class B2(A2): # E: Cannot extend enum with existing members: "A2" | |||
| class A3(Enum): | |||
| x: Final[int] # type: ignore | |||
| class B3(A3): | |||
| x = 1 # E: Cannot override final attribute "x" (previously declared in base class "A3") | |||
|
|
|||
| x = 1 # E: Cannot override final attribute "x" (previously declared in base class "A3") \ | |||
There was a problem hiding this comment.
Note that this (and other equivalent) change is correct: as per the spec, unannotated attrs should be interpreted as nonmembers, so, strictly speaking, you're assigning a soon-to-become enum instance to something of type int, breaking the interface. And it doesn't matter much as there is already another diagnostic on this line.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
sobolevn
reviewed
Jul 11, 2025
JukkaL
reviewed
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11368 (apparently canonical).
Fixes #10910.
Fixes #12107.
Fixes #13841.
Fixes #15186.
Fixes #15454.
Fixes #19418.
mypynow understands attribute access on enum members - the "recursive" behaviour of supporting access of almost-all enum members from members. "Almost", because.nameand.valuetake precedence even if a member of the same name exists.Looks like this is a much wanted feature.